gcc/gcc-TEST
gcc/gcc-TEST
18
Fork 33
forked from gcc/gcc-mirror
Code Issues Pull requests 33 Wiki Activity Actions

libgccjit: Add support for packed struct #111

Open
antoyo wants to merge 1 commit from antoyo/gcc:gccjit/packed-type into trunk
pull from: antoyo/gcc:gccjit/packed-type
merge into: gcc:trunk
Conversation 9 Commits 1 Files changed 12 +295 -6
antoyo commented 2025-10-17 15:45:42 +00:00
Member
Copy link
gcc/jit/ChangeLog:

	* docs/topics/compatibility.rst (LIBGCCJIT_ABI_36): New ABI tag.
	* docs/topics/types.rst: Document gcc_jit_type_add_attribute and
	gcc_jit_type_attribute.
	* dummy-frontend.cc (attr_aligned_exclusions): New variable.
	(handle_packed_attribute): New function.
	* jit-playback.cc: Handle type attributes.
	(type_attribute_to_string): New function.
	* jit-playback.h: New parameter attributes to new_compound_type.
	* jit-recording.cc (recording::type::add_attribute): New method.
	* jit-recording.h (recording::type::add_attribute): New method.
	(m_attributes): New field.
	* libgccjit.cc (gcc_jit_type_add_attribute): New function.
	* libgccjit.h (gcc_jit_type_add_attribute): New function.
	(gcc_jit_type_attribute): New enum.
	* libgccjit.map (LIBGCCJIT_ABI_36): New ABI tag.

gcc/testsuite/ChangeLog:

	* jit.dg/all-non-failing-tests.h: Mention new test.
	* jit.dg/test-packed-struct.c: New test.

CC: David Malcolm dmalcolm@redhat.com, jit@gcc.gnu.org

``` gcc/jit/ChangeLog: * docs/topics/compatibility.rst (LIBGCCJIT_ABI_36): New ABI tag. * docs/topics/types.rst: Document gcc_jit_type_add_attribute and gcc_jit_type_attribute. * dummy-frontend.cc (attr_aligned_exclusions): New variable. (handle_packed_attribute): New function. * jit-playback.cc: Handle type attributes. (type_attribute_to_string): New function. * jit-playback.h: New parameter attributes to new_compound_type. * jit-recording.cc (recording::type::add_attribute): New method. * jit-recording.h (recording::type::add_attribute): New method. (m_attributes): New field. * libgccjit.cc (gcc_jit_type_add_attribute): New function. * libgccjit.h (gcc_jit_type_add_attribute): New function. (gcc_jit_type_attribute): New enum. * libgccjit.map (LIBGCCJIT_ABI_36): New ABI tag. gcc/testsuite/ChangeLog: * jit.dg/all-non-failing-tests.h: Mention new test. * jit.dg/test-packed-struct.c: New test. ``` CC: David Malcolm <dmalcolm@redhat.com>, <jit@gcc.gnu.org>
forge-bot commented 2025-10-17 15:46:01 +00:00
Member
Copy link

Welcome to Sourceware Forge

Hi @antoyo, and thanks for your PR. This bot helps you send your patch series to the mailing list.

Please follow these guidelines to ensure a smooth submission.

Writing a Good PR Description

  • If your PR has multiple commits, write a meaningful description. It becomes the cover letter.
  • For a single commit, you can leave the description empty if the commit message is clear.

To CC reviewers, add at the end of your PR description one or more lines like this:

CC: Revi Ewer <revi.ewer@example.com>, Ill Takalook <ill.takalook@example.net>

Avoid copy-pasting a CC list from a previous PR. Doing so may cause failure to send the emails properly.

We recommend reviewing your commit messages carefully before submitting.

This project expects a specific format.
See Submitting Patches for details

Submitting Your Patch

To submit, you must be authorized. Ask any permitted contributor to authorize you by commenting: /allow. This is anyone who has been /allowed before.

Once allowed, comment: /submit

Use /preview to see the emails before sending. (Requires a public forge email.)

Responding to Reviews

Watch for replies on the mailing list. If not subscribed, you can reply by:

  1. Visiting inbox.sourceware.org
  2. Clicking (raw) on the email
  3. Importing it into your mail client

For Gmail:

curl -g --user "<Email>:<Password>" \
  --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

Updating Your PR

  1. Push new commits, rebase and force push changes to the same branch as needed
  2. Update the PR description with a “Changes since vX” section
  3. Comment again with: /submit

Need help?

Consider joining the gcc and gcc-patches mailing lists..
For real time communication, check the gcc irc channels.

Or join #overseers on Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).

<!-- pr-welcome --> # Welcome to Sourceware Forge Hi @antoyo, and thanks for your PR. This bot helps you send your patch series to the mailing list. Please follow these guidelines to ensure a smooth submission. ## Writing a Good PR Description - If your PR has **multiple commits**, write a meaningful description. It becomes the cover letter. - For **a single commit**, you can leave the description empty if the commit message is clear. To CC reviewers, add at the end of your PR description one or more lines like this: ```text CC: Revi Ewer <revi.ewer@example.com>, Ill Takalook <ill.takalook@example.net> ``` Avoid copy-pasting a CC list from a previous PR. Doing so may cause failure to send the emails properly. We recommend reviewing your commit messages carefully before submitting. This project expects a specific format. See [Submitting Patches](https://gcc.gnu.org/contribute.html#patches) for details ## Submitting Your Patch To submit, you must be authorized. Ask any permitted contributor to authorize you by commenting: `/allow`. This is anyone who has been `/allow`ed before. Once allowed, comment: `/submit` Use `/preview` to see the emails before sending. (Requires a public forge email.) ## Responding to Reviews Watch for replies on the mailing list. If not subscribed, you can reply by: 1. Visiting [inbox.sourceware.org](https://inbox.sourceware.org) 2. Clicking `(raw)` on the email 3. Importing it into your mail client For Gmail: ```sh curl -g --user "<Email>:<Password>" \ --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt ``` ## Updating Your PR 1. Push new commits, rebase and force push changes to the same branch as needed 2. Update the PR description with a “Changes since vX” section 3. Comment again with: `/submit` ## Need help? Consider joining the [gcc and gcc-patches mailing lists.](https://gcc.gnu.org/lists.html). For real time communication, check the [gcc irc channels](https://gcc.gnu.org/wiki/GCConIRC). Or join [`#overseers`](https://web.libera.chat/#overseers) on Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).
antoyo force-pushed gccjit/packed-type from 5209f558bc to 293f9f9690 2025-10-17 16:17:50 +00:00 Compare
antoyo commented 2025-10-17 16:22:40 +00:00
Author
Member
Copy link

/submit

/submit
forge-bot commented 2025-10-17 16:23:09 +00:00
Member
Copy link

Version 1 of this pull request has been stored. It includes the following commits:

  • libgccjit: Add support for packed struct - 293f9f9690
<!-- pr-new-version --> Version 1 of this pull request has been stored. It includes the following commits: - libgccjit: Add support for packed struct - 293f9f9690960fdd984a993ed77132ca6dccccf5
forge-bot commented 2025-10-17 16:23:10 +00:00
Member
Copy link

Pull Request versions:

# Base Head
1 7cd91c7c42 293f9f9690 (diff)

In order to compare , clone this repository and run

PR=111
git fetch origin "refs/versioned_pull/${PR}/*:refs/versioned_pull/${PR}/*"
PRV1=1
PRV2=2
git range-diff "refs/versioned_pull/${PR}/${PRV1}/base..refs/versioned_pull/${PR}/${PRV1}/head"  "refs/versioned_pull/${PR}/${PRV2}/base..refs/versioned_pull/${PR}/${PRV2}/head"
<!-- pr-versions --> Pull Request versions: | # | Base | Head | | | - | ---- | ---- | - | | 1 | 7cd91c7c42eec894c8c13fa68ccc12ec3a047c9a | 293f9f9690960fdd984a993ed77132ca6dccccf5 | [(diff)](https://forge.sourceware.org/gcc/gcc-TEST.git/compare/7cd91c7c42eec894c8c13fa68ccc12ec3a047c9a...293f9f9690960fdd984a993ed77132ca6dccccf5) | In order to compare , clone this repository and run ``` PR=111 git fetch origin "refs/versioned_pull/${PR}/*:refs/versioned_pull/${PR}/*" PRV1=1 PRV2=2 git range-diff "refs/versioned_pull/${PR}/${PRV1}/base..refs/versioned_pull/${PR}/${PRV1}/head" "refs/versioned_pull/${PR}/${PRV2}/base..refs/versioned_pull/${PR}/${PRV2}/head" ```
forge-bot commented 2025-10-17 16:23:44 +00:00
Member
Copy link

Sent patch series version 1 containing 1 patches to gcc-patches mailing list test-list@sourceware.org and cc'd David Malcolm dmalcolm@redhat.com, jit@gcc.gnu.org.
Cover letter

Sent patch series version 1 containing 1 patches to gcc-patches mailing list <test-list@sourceware.org> and cc'd David Malcolm <dmalcolm@redhat.com>, <jit@gcc.gnu.org>. [Cover letter](https://inbox.sourceware.org/test-list/176071819122.1193.9848651491117142013.batrachomyomachia.gcc.gcc-TEST.111.1.0@forge-test.rdfm.org)
pinskia reviewed 2025-10-17 20:49:50 +00:00
gcc/jit/docs/topics/types.rst
@ -558,0 +572,4 @@
.. macro:: GCC_JIT_TYPE_ATTRIBUTE_PACKED
Packed structures or union have each of its members placed to
minimize the memory required.
pinskia commented 2025-10-17 20:49:50 +00:00
Member
Copy link

This definition of the packed attribute is incorrect. Rather it does not describe the reality of things. Because to me it says the order of the fields could be reorded.
And if anything should point to the GCC documentation on the attribute:
https://gcc.gnu.org/onlinedocs/gcc/Common-Type-Attributes.html#index-packed-type-attribute .

This definition of the packed attribute is incorrect. Rather it does not describe the reality of things. Because to me it says the order of the fields could be reorded. And if anything should point to the GCC documentation on the attribute: https://gcc.gnu.org/onlinedocs/gcc/Common-Type-Attributes.html#index-packed-type-attribute .
antoyo commented 2025-10-18 11:43:26 +00:00
Author
Member
Copy link

The sentence I wrote here was actually a shortened version of the first sentence of the doc you linked…
I can link to the doc, though.

The sentence I wrote here was actually a shortened version of the first sentence of the doc you linked… I can link to the doc, though.
pinskia reviewed 2025-10-17 20:50:32 +00:00
gcc/jit/dummy-frontend.cc
@ -41,2 +41,4 @@
using namespace gcc::jit;
#define DECL_C_BIT_FIELD(NODE) \
(DECL_LANG_FLAG_4 (FIELD_DECL_CHECK (NODE)) == 1)
pinskia commented 2025-10-17 20:50:32 +00:00
Member
Copy link

Why add this if you don't set DECL_LANG_FLAG_4 at all?

Why add this if you don't set DECL_LANG_FLAG_4 at all?
antoyo commented 2025-10-18 11:45:03 +00:00
Author
Member
Copy link

DECL_LANG_FLAG_4 comes from tree.h.

`DECL_LANG_FLAG_4` comes from `tree.h`.
linaroci commented 2025-10-25 10:33:21 +00:00
First-time contributor
Copy link

CI state: fail ❌
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/89/ : CI bot tcwg_gnu_cross_build--master-aarch64: Patch failed to apply
See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/89/artifact/artifacts/jenkins/precommit-forge-apply.log

<!-- linaro-ci-status CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/89/ --> CI state: fail :x: CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/89/ : CI bot tcwg_gnu_cross_build--master-aarch64: Patch failed to apply See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/89/artifact/artifacts/jenkins/precommit-forge-apply.log
linaroci commented 2025-10-25 19:18:10 +00:00
First-time contributor
Copy link

CI state: fail ❌
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/117/ : CI bot tcwg_gnu_cross_build--master-arm: Patch failed to apply
See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/117/artifact/artifacts/jenkins/precommit-forge-apply.log

<!-- linaro-ci-status CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/117/ --> CI state: fail :x: CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/117/ : CI bot tcwg_gnu_cross_build--master-arm: Patch failed to apply See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/117/artifact/artifacts/jenkins/precommit-forge-apply.log
This pull request has changes conflicting with the target branch.
  • gcc/jit/docs/topics/compatibility.rst
  • gcc/jit/libgccjit.h
  • gcc/jit/libgccjit.map
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u gccjit/packed-type:antoyo-gccjit/packed-type
git switch antoyo-gccjit/packed-type

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch trunk
git merge --no-ff antoyo-gccjit/packed-type
git switch antoyo-gccjit/packed-type
git rebase trunk
git switch trunk
git merge --ff-only antoyo-gccjit/packed-type
git switch antoyo-gccjit/packed-type
git rebase trunk
git switch trunk
git merge --no-ff antoyo-gccjit/packed-type
git switch trunk
git merge --squash antoyo-gccjit/packed-type
git switch trunk
git merge --ff-only antoyo-gccjit/packed-type
git switch trunk
git merge antoyo-gccjit/packed-type
git push origin trunk
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Frontend/ada

   
Frontend/c

   
Frontend/c++

   
General/forge

Forgejo infrastructure

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Library/libgcc

   
Library/libstdc++

   
Midend/gimple

   
Midend/rtl

   
Midend/tree
  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Target/aarch64

   
Target/arm

   
Target/i386
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
Compat/Breaking
Frontend/ada
Frontend/c
Frontend/c++
General/forge
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Library/libgcc
Library/libstdc++
Midend/gimple
Midend/rtl
Midend/tree
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Target/aarch64
Target/arm
Target/i386
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
gcc/gcc-TEST!111
No description provided.