forked from gcc/gcc-mirror
libgccjit: Fix UB in constructor functions #124
No reviewers
Labels
No labels
Compat/Breaking
Frontend/ada
Frontend/c
Frontend/c++
General/forge
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Library/libgcc
Library/libstdc++
Midend/gimple
Midend/rtl
Midend/tree
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Target/aarch64
Target/arm
Target/i386
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
gcc/gcc-TEST!124
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "antoyo/gcc:fix/gccjit-cast-ub"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
CC: David Malcolm dmalcolm@redhat.com, jit@gcc.gnu.org
Welcome to Sourceware Forge
Hi @antoyo, and thanks for your PR. This bot helps you send your patch series to the mailing list.
Please follow these guidelines to ensure a smooth submission.
Writing a Good PR Description
To CC reviewers, add at the end of your PR description one or more lines like this:
Avoid copy-pasting a CC list from a previous PR. Doing so may cause failure to send the emails properly.
We recommend reviewing your commit messages carefully before submitting.
This project expects a specific format.
See Submitting Patches for details
Submitting Your Patch
To submit, you must be authorized. Ask any permitted contributor to authorize you by commenting:
/allow. This is anyone who has been/allowed before.Once allowed, comment:
/submitUse
/previewto see the emails before sending. (Requires a public forge email.)Responding to Reviews
Watch for replies on the mailing list. If not subscribed, you can reply by:
(raw)on the emailFor Gmail:
Updating Your PR
/submitNeed help?
Consider joining the gcc and gcc-patches mailing lists..
For real time communication, check the gcc irc channels.
Or join
#overseerson Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).I checked all the other usages of
reinterpret_castinlibgccjitand they seem safe.Could someone please double-check that?
@ -0,0 +67,4 @@one,};struct_value =gcc_jit_context_new_struct_constructor (ctxt, NULL, aligned_struct_type,This doesn't seem to trigger the bug in this test on my computer, unfortunately.
The issue is that since it's UB,
n_elcan get any value and it's often greater than the number of values provided by this function since the latter is very small.I'm not sure if there would be a better way to test this.
/submit
Version 1 of this pull request has been stored. It includes the following commits:
992085c6aePull Request versions:
7a5a92a643992085c6aeIn order to compare , clone this repository and run
Sent patch series version 1 containing 1 patches to gcc-patches mailing list gcc-patches@gcc.gnu.org and cc'd David Malcolm dmalcolm@redhat.com, jit@gcc.gnu.org.
Cover letter
CI state: success ✅
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/141/ : CI bot tcwg_gnu_cross_build--master-arm: Build results
See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/141/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
CI state: success ✅
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/120/ : CI bot tcwg_gnu_cross_build--master-aarch64: Build results
See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/120/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
CI state: success ✅
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/134/ : CI bot tcwg_gnu_cross_check_gcc--master-arm: Test results
See: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/134/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
CI state: success ✅
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/86/ : CI bot tcwg_gnu_cross_check_gcc--master-aarch64: Test results
See: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/86/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.