libgccjit: Fix test-cold-attribute.c #129

Closed
antoyo wants to merge 1 commit from antoyo/gcc:fix/jit-test-cold-attribute into trunk
Member
gcc/testsuite/ChangeLog:

	* jit.dg/test-cold-attribute.c: Use -Oz to fix test.

CC: David Malcolm dmalcolm@redhat.com, jit@gcc.gnu.org

``` gcc/testsuite/ChangeLog: * jit.dg/test-cold-attribute.c: Use -Oz to fix test. ``` CC: David Malcolm <dmalcolm@redhat.com>, <jit@gcc.gnu.org>
libgccjit: Fix test-cold-attribute.c
All checks were successful
/ testjob (pull_request) Successful in 51s
f67d0e99a9
gcc/testsuite/ChangeLog:

	* jit.dg/test-cold-attribute.c: Use -Oz to fix test.
Member

Welcome to Sourceware Forge

Hi @antoyo, and thanks for your PR. This bot helps you send your patch series to the mailing list.

Please follow these guidelines to ensure a smooth submission.

Writing a Good PR Description

  • If your PR has multiple commits, write a meaningful description. It becomes the cover letter.
  • For a single commit, you can leave the description empty if the commit message is clear.

To CC reviewers, add at the end of your PR description one or more lines like this:

CC: Revi Ewer <revi.ewer@example.com>, Ill Takalook <ill.takalook@example.net>

Avoid copy-pasting a CC list from a previous PR. Doing so may cause failure to send the emails properly.

We recommend reviewing your commit messages carefully before submitting.

This project expects a specific format.
See Submitting Patches for details

Submitting Your Patch

To submit, you must be authorized. Ask any permitted contributor to authorize you by commenting: /allow. This is anyone who has been /allowed before.

Once allowed, comment: /submit

Use /preview to see the emails before sending. (Requires a public forge email.)

Responding to Reviews

Watch for replies on the mailing list. If not subscribed, you can reply by:

  1. Visiting inbox.sourceware.org
  2. Clicking (raw) on the email
  3. Importing it into your mail client

For Gmail:

curl -g --user "<Email>:<Password>" \
  --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

Updating Your PR

  1. Push new commits, rebase and force push changes to the same branch as needed
  2. Update the PR description with a “Changes since vX” section
  3. Comment again with: /submit

Need help?

Consider joining the gcc and gcc-patches mailing lists..
For real time communication, check the gcc irc channels.

Or join #overseers on Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).

<!-- pr-welcome --> # Welcome to Sourceware Forge Hi @antoyo, and thanks for your PR. This bot helps you send your patch series to the mailing list. Please follow these guidelines to ensure a smooth submission. ## Writing a Good PR Description - If your PR has **multiple commits**, write a meaningful description. It becomes the cover letter. - For **a single commit**, you can leave the description empty if the commit message is clear. To CC reviewers, add at the end of your PR description one or more lines like this: ```text CC: Revi Ewer <revi.ewer@example.com>, Ill Takalook <ill.takalook@example.net> ``` Avoid copy-pasting a CC list from a previous PR. Doing so may cause failure to send the emails properly. We recommend reviewing your commit messages carefully before submitting. This project expects a specific format. See [Submitting Patches](https://gcc.gnu.org/contribute.html#patches) for details ## Submitting Your Patch To submit, you must be authorized. Ask any permitted contributor to authorize you by commenting: `/allow`. This is anyone who has been `/allow`ed before. Once allowed, comment: `/submit` Use `/preview` to see the emails before sending. (Requires a public forge email.) ## Responding to Reviews Watch for replies on the mailing list. If not subscribed, you can reply by: 1. Visiting [inbox.sourceware.org](https://inbox.sourceware.org) 2. Clicking `(raw)` on the email 3. Importing it into your mail client For Gmail: ```sh curl -g --user "<Email>:<Password>" \ --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt ``` ## Updating Your PR 1. Push new commits, rebase and force push changes to the same branch as needed 2. Update the PR description with a “Changes since vX” section 3. Comment again with: `/submit` ## Need help? Consider joining the [gcc and gcc-patches mailing lists.](https://gcc.gnu.org/lists.html). For real time communication, check the [gcc irc channels](https://gcc.gnu.org/wiki/GCConIRC). Or join [`#overseers`](https://web.libera.chat/#overseers) on Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).
Author
Member

/submit

/submit
Member

Version 1 of this pull request has been stored. It includes the following commits:

  • libgccjit: Fix test-cold-attribute.c - f67d0e99a9
<!-- pr-new-version --> Version 1 of this pull request has been stored. It includes the following commits: - libgccjit: Fix test-cold-attribute.c - f67d0e99a93e2e1f7c6d8de0ae28596c0c103534
Member

Pull Request versions:

# Base Head
1 56c6612598 f67d0e99a9 (diff)

In order to compare , clone this repository and run

PR=129
git fetch origin "refs/versioned_pull/${PR}/*:refs/versioned_pull/${PR}/*"
PRV1=1
PRV2=2
git range-diff "refs/versioned_pull/${PR}/${PRV1}/base..refs/versioned_pull/${PR}/${PRV1}/head"  "refs/versioned_pull/${PR}/${PRV2}/base..refs/versioned_pull/${PR}/${PRV2}/head"
<!-- pr-versions --> Pull Request versions: | # | Base | Head | | | - | ---- | ---- | - | | 1 | 56c6612598a07514a65ad5c0b25d12d1fc966e4c | f67d0e99a93e2e1f7c6d8de0ae28596c0c103534 | [(diff)](https://forge.sourceware.org/gcc/gcc-TEST.git/compare/56c6612598a07514a65ad5c0b25d12d1fc966e4c...f67d0e99a93e2e1f7c6d8de0ae28596c0c103534) | In order to compare , clone this repository and run ``` PR=129 git fetch origin "refs/versioned_pull/${PR}/*:refs/versioned_pull/${PR}/*" PRV1=1 PRV2=2 git range-diff "refs/versioned_pull/${PR}/${PRV1}/base..refs/versioned_pull/${PR}/${PRV1}/head" "refs/versioned_pull/${PR}/${PRV2}/base..refs/versioned_pull/${PR}/${PRV2}/head" ```
Member

Sent patch series version 1 containing 1 patches to gcc-patches mailing list gcc-patches@gcc.gnu.org and cc'd David Malcolm dmalcolm@redhat.com, jit@gcc.gnu.org.
Cover letter

Sent patch series version 1 containing 1 patches to gcc-patches mailing list <gcc-patches@gcc.gnu.org> and cc'd David Malcolm <dmalcolm@redhat.com>, <jit@gcc.gnu.org>. [Cover letter](https://inbox.sourceware.org/gcc-patches/bmm.hdlblk47iq.gcc.gcc-TEST.antoyo.129.1.0@forge-stage.sourceware.org)
First-time contributor
<!-- linaro-ci-status CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/155/ --> CI state: success :white_check_mark: CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/155/ : CI bot tcwg_gnu_cross_build--master-arm: Build results See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/155/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
First-time contributor
<!-- linaro-ci-status CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/131/ --> CI state: success :white_check_mark: CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/131/ : CI bot tcwg_gnu_cross_build--master-aarch64: Build results See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/131/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
First-time contributor

CI state: success
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/ : CI bot tcwg_gnu_cross_check_gcc--master-arm: Test results
See: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/artifact/artifacts/artifacts.precommit/notify/mail-body.txt

Dear contributor,

Our automatic CI successfully passed with your patch(es). Please find some details below.

In  master-arm, after:
  | gcc patch https://forge.sourceware.org/gcc/gcc-TEST/pulls/129
  | Author: Antoni Boucher <bouanto@zoho.com>
  | Date:   Thu Dec 4 11:06:07 2025 -0500
  | 
  |     [PATCH] libgccjit: Fix test-cold-attribute.c
  |     
  |     gcc/testsuite/ChangeLog:
  |     
  |             * jit.dg/test-cold-attribute.c: Use -Oz to fix test.
  | ... applied on top of baseline commit:
  | bc46466ec769 [PATCH] prepare-commit-msg: Add compatibility check for --default-prefix option


Used configuration :
 *CI config* tcwg_gnu_cross_check_gcc master-arm
 *configure and test flags:* --target arm-linux-gnueabihf 

If you have any questions regarding this report, please ask on linaro-toolchain@lists.linaro.org mailing list.

-----------------8<--------------------------8<--------------------------8<--------------------------

The information below contains the details of the failures, and the ways to reproduce a debug environment:

You can find the failure logs in *.log.1.xz files in
 * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/artifact/artifacts/artifacts.precommit/00-sumfiles/
The full lists of regressions and improvements as well as configure and make commands are in
 * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/artifact/artifacts/artifacts.precommit/notify/
The list of [ignored] baseline and flaky failures are in
 * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/artifact/artifacts/artifacts.precommit/sumfiles/xfails.xfail

Current build   : https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/artifact/artifacts
Reference build : https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-build/2462/artifact/artifacts

Warning: we do not enable maintainer-mode nor automatically update
generated files, which may lead to failures if the patch modifies the
master files.

<!-- linaro-ci-status CI bot https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/ --> CI state: success :white_check_mark: CI bot https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/ : CI bot tcwg_gnu_cross_check_gcc--master-arm: Test results See: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/artifact/artifacts/artifacts.precommit/notify/mail-body.txt ``` Dear contributor, Our automatic CI successfully passed with your patch(es). Please find some details below. In master-arm, after: | gcc patch https://forge.sourceware.org/gcc/gcc-TEST/pulls/129 | Author: Antoni Boucher <bouanto@zoho.com> | Date: Thu Dec 4 11:06:07 2025 -0500 | | [PATCH] libgccjit: Fix test-cold-attribute.c | | gcc/testsuite/ChangeLog: | | * jit.dg/test-cold-attribute.c: Use -Oz to fix test. | ... applied on top of baseline commit: | bc46466ec769 [PATCH] prepare-commit-msg: Add compatibility check for --default-prefix option Used configuration : *CI config* tcwg_gnu_cross_check_gcc master-arm *configure and test flags:* --target arm-linux-gnueabihf If you have any questions regarding this report, please ask on linaro-toolchain@lists.linaro.org mailing list. -----------------8<--------------------------8<--------------------------8<-------------------------- The information below contains the details of the failures, and the ways to reproduce a debug environment: You can find the failure logs in *.log.1.xz files in * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/artifact/artifacts/artifacts.precommit/00-sumfiles/ The full lists of regressions and improvements as well as configure and make commands are in * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/artifact/artifacts/artifacts.precommit/notify/ The list of [ignored] baseline and flaky failures are in * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/artifact/artifacts/artifacts.precommit/sumfiles/xfails.xfail Current build : https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/139/artifact/artifacts Reference build : https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-build/2462/artifact/artifacts Warning: we do not enable maintainer-mode nor automatically update generated files, which may lead to failures if the patch modifies the master files. ```
First-time contributor

CI state: success
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/ : CI bot tcwg_gnu_cross_check_gcc--master-aarch64: Test results
See: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/artifact/artifacts/artifacts.precommit/notify/mail-body.txt

Dear contributor,

Our automatic CI successfully passed with your patch(es). Please find some details below.

In  master-aarch64, after:
  | gcc patch https://forge.sourceware.org/gcc/gcc-TEST/pulls/129
  | Author: Antoni Boucher <bouanto@zoho.com>
  | Date:   Thu Dec 4 11:06:07 2025 -0500
  | 
  |     [PATCH] libgccjit: Fix test-cold-attribute.c
  |     
  |     gcc/testsuite/ChangeLog:
  |     
  |             * jit.dg/test-cold-attribute.c: Use -Oz to fix test.
  | ... applied on top of baseline commit:
  | fae0c626250 final_cleanup: Call make_forwarders_with_degenerate_phis [PR46555]


Used configuration :
 *CI config* tcwg_gnu_cross_check_gcc master-aarch64
 *configure and test flags:* --target aarch64-linux-gnu 

If you have any questions regarding this report, please ask on linaro-toolchain@lists.linaro.org mailing list.

-----------------8<--------------------------8<--------------------------8<--------------------------

The information below contains the details of the failures, and the ways to reproduce a debug environment:

You can find the failure logs in *.log.1.xz files in
 * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/artifact/artifacts/artifacts.precommit/00-sumfiles/
The full lists of regressions and improvements as well as configure and make commands are in
 * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/artifact/artifacts/artifacts.precommit/notify/
The list of [ignored] baseline and flaky failures are in
 * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/artifact/artifacts/artifacts.precommit/sumfiles/xfails.xfail

Current build   : https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/artifact/artifacts
Reference build : https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-build/2463/artifact/artifacts

Warning: we do not enable maintainer-mode nor automatically update
generated files, which may lead to failures if the patch modifies the
master files.

<!-- linaro-ci-status CI bot https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/ --> CI state: success :white_check_mark: CI bot https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/ : CI bot tcwg_gnu_cross_check_gcc--master-aarch64: Test results See: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/artifact/artifacts/artifacts.precommit/notify/mail-body.txt ``` Dear contributor, Our automatic CI successfully passed with your patch(es). Please find some details below. In master-aarch64, after: | gcc patch https://forge.sourceware.org/gcc/gcc-TEST/pulls/129 | Author: Antoni Boucher <bouanto@zoho.com> | Date: Thu Dec 4 11:06:07 2025 -0500 | | [PATCH] libgccjit: Fix test-cold-attribute.c | | gcc/testsuite/ChangeLog: | | * jit.dg/test-cold-attribute.c: Use -Oz to fix test. | ... applied on top of baseline commit: | fae0c626250 final_cleanup: Call make_forwarders_with_degenerate_phis [PR46555] Used configuration : *CI config* tcwg_gnu_cross_check_gcc master-aarch64 *configure and test flags:* --target aarch64-linux-gnu If you have any questions regarding this report, please ask on linaro-toolchain@lists.linaro.org mailing list. -----------------8<--------------------------8<--------------------------8<-------------------------- The information below contains the details of the failures, and the ways to reproduce a debug environment: You can find the failure logs in *.log.1.xz files in * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/artifact/artifacts/artifacts.precommit/00-sumfiles/ The full lists of regressions and improvements as well as configure and make commands are in * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/artifact/artifacts/artifacts.precommit/notify/ The list of [ignored] baseline and flaky failures are in * https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/artifact/artifacts/artifacts.precommit/sumfiles/xfails.xfail Current build : https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/89/artifact/artifacts Reference build : https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-build/2463/artifact/artifacts Warning: we do not enable maintainer-mode nor automatically update generated files, which may lead to failures if the patch modifies the master files. ```
Member

Looks good, but I notice that all-non-failing-tests.h has a comment referring to the -O2 in this file, so that should also be updated to something like:

/* test-cold-attribute.c: This can't be in the testcases array as it needs a specific optimization flag. */

or similar.

OK with that change.

Looks good, but I notice that all-non-failing-tests.h has a comment referring to the -O2 in this file, so that should also be updated to something like: /* test-cold-attribute.c: This can't be in the testcases array as it needs a specific optimization flag. */ or similar. OK with that change.
antoyo force-pushed fix/jit-test-cold-attribute from f67d0e99a9
All checks were successful
/ testjob (pull_request) Successful in 51s
to c6109d0027
All checks were successful
/ testjob (pull_request) Successful in 1m5s
2025-12-17 15:52:07 +00:00
Compare
First-time contributor
<!-- linaro-ci-status CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/133/ --> CI state: success :white_check_mark: CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/133/ : CI bot tcwg_gnu_cross_build--master-aarch64: Build results See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/133/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
First-time contributor
<!-- linaro-ci-status CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/157/ --> CI state: success :white_check_mark: CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/157/ : CI bot tcwg_gnu_cross_build--master-arm: Build results See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/157/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
Author
Member

Merged.

Merged.
antoyo closed this pull request 2025-12-21 14:24:11 +00:00
All checks were successful
/ testjob (pull_request) Successful in 1m5s

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
gcc/gcc-TEST!129
No description provided.