forked from gcc/gcc-mirror
libgccjit: Add gcc_jit_type_is_floating_point #74
No reviewers
Labels
No labels
Compat/Breaking
Frontend/ada
Frontend/c
Frontend/c++
General/forge
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Library/libgcc
Library/libstdc++
Midend/gimple
Midend/rtl
Midend/tree
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Target/aarch64
Target/arm
Target/i386
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Depends on
Reference
gcc/gcc-TEST!74
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "antoyo/gcc:gccjit-is-floating-point"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
CC: David Malcolm dmalcolm@redhat.com, jit@gcc.gnu.org
Welcome to Sourceware Forge
Hi @antoyo, and thanks for your PR. This bot helps you send your patch series to the mailing list.
Please follow these guidelines to ensure a smooth submission.
Writing a Good PR Description
To CC reviewers, add to your PR description:
Avoid copy-pasting a CC list from a previous PR. Doing so may cause failure to send the emails properly.
We recommend reviewing your commit messages carefully before submitting.
This project expects a specific format.
See Submitting Patches for details
Submitting Your Patch
To submit, you must be authorized. Ask any permitted contributor to authorize you by commenting:
/allow. This is anyone who has been/allowed before.Once allowed, comment:
/submitUse
/previewto see the emails before sending. (Requires a public forge email.)Responding to Reviews
Watch for replies on the mailing list. If not subscribed, you can reply by:
(raw)on the emailFor Gmail:
Updating Your PR
/submitNeed help?
Consider joining the gcc and gcc-patches mailing lists..
For real time communication, check the gcc irc channels.
Or join
#overseerson Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).677fd7be8cto90ab6e135eCI state: success ✅
CI bot tcwg_gnu_cross_build--master-aarch64 : CI bot tcwg_gnu_cross_build--master-aarch64: Build results
See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/19/
/submit
CI state: success ✅
CI bot tcwg_gnu_cross_build--master-arm : CI bot tcwg_gnu_cross_build--master-arm: Build results
See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/42/
CI state: success ✅
CI bot tcwg_gnu_cross_check_gcc--master-aarch64 : CI bot tcwg_gnu_cross_check_gcc--master-aarch64: Test results
See: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/52/
CI state: success ✅
CI bot tcwg_gnu_cross_check_gcc--master-arm : CI bot tcwg_gnu_cross_check_gcc--master-arm: Test results
See: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/90/
/allow
/submit
Version 1 of this pull request has been stored. It includes the following commits:
90ab6e135ePull Request versions:
6b6a2d461b90ab6e135eIn order to compare , clone this repository and run
Sent patch series version 1 containing 1 patches to gcc-patches mailing list test-list@sourceware.org.
Cover letter
Looks reasonable, but in the test coverage I see uses of
gcc_jit_context_get_target_infoandgcc_jit_target_info_supports_target_dependent_type; is this dependent on another patch? (and is that one stuck on review?)Alternatively, this could lose the parts of the test coverage that use
gcc_jit_target_infoand go ahead into trunk.@ -433,0 +440,4 @@.. code-block:: c#ifdef LIBGCCJIT_HAVE_gcc_jit_context_set_output_identOops, this is the wrong
#ifdef@ -27,0 +34,4 @@gcc_jit_target_info *target_info = gcc_jit_context_get_target_info(ctxt);if (target_info != NULL && gcc_jit_target_info_supports_target_dependent_type(target_info, GCC_JIT_TYPE_FLOAT16)){I see uses of gcc_jit_context_get_target_info and gcc_jit_target_info_supports_target_dependent_type; is this dependent on another patch? (and is that one stuck on review?)
Alternatively, this could lose the parts of the test coverage that use gcc_jit_target_info and go ahead into trunk.
Oh yeah, this test depends on this patch.
I'm blocked because I'm not sure what to do with the fact that
host_detect_local_cpuis not available for cross-compilers. Do you have an idea of how to fix that?Thanks.
Oh, it also uses the sized types (like
GCC_JIT_TYPE_FLOAT16) which are not upstream either.I'll send the patch for this.
Sorry about that.
I got unblocked and I updated the patch for cpu features detection that is blocking this PR.
@dmalcolm: Could you please review that patch?
I also updated this PR to fix the
ifdefThanks.
@antoyo wrote in #74 (comment):
Those were added in #82..
The required patch was merged.
Now, the only thing missing is merging the dependent pull request (edit: Done).
Not quite ready as-is; see the comments above.
90ab6e135eto7a4e1dd300CI state: success ✅
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/81/ : CI bot tcwg_gnu_cross_build--master-arm: Build results
See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/81/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
CI state: success ✅
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/57/ : CI bot tcwg_gnu_cross_build--master-aarch64: Build results
See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/57/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
7a4e1dd300toc8a5f252f0c8a5f252f0c9456a7d62c9456a7d625702d95898CI state: success ✅
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/92/ : CI bot tcwg_gnu_cross_build--master-aarch64: Build results
See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-aarch64-precommit/92/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
CI state: success ✅
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/120/ : CI bot tcwg_gnu_cross_build--master-arm: Build results
See: https://ci.linaro.org/job/tcwg_gnu_cross_build--master-arm-precommit/120/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
CI state: success ✅
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/114/ : CI bot tcwg_gnu_cross_check_gcc--master-arm: Test results
See: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-precommit/114/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
CI state: success ✅
CI bot https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/76/ : CI bot tcwg_gnu_cross_check_gcc--master-aarch64: Test results
See: https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-aarch64-precommit/76/artifact/artifacts/artifacts.precommit/notify/mail-body.txt
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.