gccrs: use range-based for loop in asm builtin #178

Open

0xllx0 wants to merge 1 commit from 0xllx0/gcc-TEST:gccrs/builtin-asm-range-based-for-loop into trunk

pull from: 0xllx0/gcc-TEST:gccrs/builtin-asm-range-based-for-loop

merge into: gcc:trunk

gcc:trunk

gcc:releases/gcc-16

gcc:releases/gcc-15

gcc:releases/gcc-14

gcc:releases/gcc-13

gcc:releases/gcc-12

gcc:releases/gcc-11

gcc:releases/gcc-10

gcc:releases/gcc-9

gcc:releases/gcc-8

gcc:releases/gcc-7

gcc:releases/gcc-6

gcc:releases/gcc-5

gcc:releases/gcc-4.9

gcc:releases/gcc-4.8

gcc:releases/gcc-4.7

gcc:releases/gcc-4.6

gcc:releases/gcc-4.5

gcc:releases/gcc-4.4

gcc:releases/gcc-4.3

gcc:releases/gcc-3.0

gcc:releases/gcc-3.2

gcc:releases/gcc-3.3

gcc:releases/gcc-3.4

gcc:releases/gcc-4.2

gcc:releases/gcc-4.1

gcc:releases/gcc-4.0

gcc:releases/gcc-3.1

gcc:releases/gcc-2.95

gcc:releases/gcc-2.95.2.1-branch

gcc:releases/libgcj-2.95

gcc:releases/egcs-1.1

gcc:releases/egcs-1.0

Conversation 2 Commits 1 Files changed 1 +1 -2

0xllx0 commented 2026-06-17 23:47:05 +00:00

Member

Copy link

Small change to use a range-based for loop in the
expand_inline_asm_strings function.

gcc/rust/Changelog:

* expand/rust-macro-builtins-asm.cc: use range-based for loop
in the `expand_inline_asm_strings` function.

Small change to use a range-based for loop in the `expand_inline_asm_strings` function. gcc/rust/Changelog: * expand/rust-macro-builtins-asm.cc: use range-based for loop in the `expand_inline_asm_strings` function.

forge-bot commented 2026-06-17 23:47:07 +00:00

Member

Copy link

Hi @0xllx0. This bot helps send your PR as a patch series to the mailing list.

Next steps

1. Write a clear PR description. It will be used as the cover letter.
2. To CC extra people, add lines like this at the end of the PR description: CC: Reviewer1 <revi.ewer@example.com>, Reviewer2 <an.other@example.com>.
3. To preview the emails, comment with /preview.
4. When ready, request review in the Reviewers section. Or, if you just want to send the series, comment with /submit.
5. Use the cover-letter links below to follow replies.
6. For a new patch series, push your changes, update the PR description with a Changes since vX section, and comment with /submit again.

See Submitting Patches and UsingForge.

Consider joining the gcc and gcc-patches mailing lists..
For real time communication, check the gcc irc channels.

Or join #overseers on Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).

<!-- pr-welcome --> Hi @0xllx0. This bot helps send your PR as a patch series to the mailing list. ## Next steps 1. Write a clear PR description. It will be used as the cover letter. 2. To CC extra people, add lines like this **at the end** of the PR description: `CC: Reviewer1 <revi.ewer@example.com>, Reviewer2 <an.other@example.com>`. 3. To preview the emails, comment with `/preview`. 4. When ready, request review in the Reviewers section. Or, if you just want to send the series, comment with `/submit`. 5. Use the cover-letter links below to follow replies. 6. For a new patch series, push your changes, update the PR description with a `Changes since vX` section, and comment with `/submit` again. See [Submitting Patches](https://gcc.gnu.org/contribute.html#patches) and [UsingForge](https://gcc.gnu.org/wiki/UsingForge). Consider joining the [gcc and gcc-patches mailing lists.](https://gcc.gnu.org/lists.html). For real time communication, check the [gcc irc channels](https://gcc.gnu.org/wiki/GCConIRC). Or join [`#overseers`](https://web.libera.chat/#overseers) on Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).

dkm commented 2026-06-18 07:20:42 +00:00

Member

Copy link

ChangeLog format should be more like:

* expand/rust-macro-builtins-asm.cc (expand_inline_asm_strings): Use range-based for loop.

:) It's really: * filename.ext (item): What changed. :)

ChangeLog format should be more like: ``` * expand/rust-macro-builtins-asm.cc (expand_inline_asm_strings): Use range-based for loop. ``` :) It's really: ` * filename.ext (item): What changed.` :)

👍 1

0xllx0 force-pushed gccrs/builtin-asm-range-based-for-loop from bc9fae9c47 to 68625165da 2026-06-18 18:14:42 +00:00 Compare

All checks were successful

Hide checks

/ format-checks (pull_request) Successful in 1m37s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u gccrs/builtin-asm-range-based-for-loop:0xllx0-gccrs/builtin-asm-range-based-for-loop

git switch 0xllx0-gccrs/builtin-asm-range-based-for-loop

Merge

Merge the changes and update on Forgejo.

git switch trunk

git merge --no-ff 0xllx0-gccrs/builtin-asm-range-based-for-loop

git switch 0xllx0-gccrs/builtin-asm-range-based-for-loop

git rebase trunk

git switch trunk

git merge --ff-only 0xllx0-gccrs/builtin-asm-range-based-for-loop

git switch 0xllx0-gccrs/builtin-asm-range-based-for-loop

git rebase trunk

git switch trunk

git merge --no-ff 0xllx0-gccrs/builtin-asm-range-based-for-loop

git switch trunk

git merge --squash 0xllx0-gccrs/builtin-asm-range-based-for-loop

git switch trunk

git merge --ff-only 0xllx0-gccrs/builtin-asm-range-based-for-loop

git switch trunk

git merge 0xllx0-gccrs/builtin-asm-range-based-for-loop

git push origin trunk

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Compat/Breaking

Breaking change that won't be backward compatible

  

Frontend/ada

  

Frontend/c

  

Frontend/c++

  

Frontend/rust

Code affecting the Rust front end

  

General/forge

Forgejo infrastructure

  

Kind/Bug

Something is not working

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Library/libgcc

  

Library/libstdc++

  

Midend/gimple

  

Midend/rtl

  

Midend/tree

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Target/aarch64

  

Target/arm

  

Target/i386

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

Compat/Breaking

Frontend/ada

Frontend/c

Frontend/c++

Frontend/rust

General/forge

Kind/Bug

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Library/libgcc

Library/libstdc++

Midend/gimple

Midend/rtl

Midend/tree

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Target/aarch64

Target/arm

Target/i386

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gcc/gcc!178

No description provided.