gcc/gcc
gcc/gcc
Watch
43
Fork
You've already forked gcc
 58
Code Issues Pull requests 58 Wiki Activity Actions

libstdc++: Simplify nullary _Flat_set_impl::_M_try_emplace overload #189

Open
ppalka wants to merge 1 commit from ppalka/ppalka-test-topic into trunk AGit
pull from: ppalka/ppalka-test-topic
merge into: gcc:trunk
Conversation 8 Commits 1 Files changed 1 +4 -5
ppalka commented 2026-07-15 20:07:17 +00:00
Member
Copy link

Remove the unused template parameter pack _Args (which always gets
deduced to an empty pack).

libstdc++-v3/ChangeLog:

* include/std/flat_set (_Flat_set_impl::_M_try_emplace):
Turn nullary overload into a non-template.
Remove the unused template parameter pack _Args (which always gets deduced to an empty pack). libstdc++-v3/ChangeLog: * include/std/flat_set (_Flat_set_impl::_M_try_emplace): Turn nullary overload into a non-template.
libstdc++: Simplify nullary _Flat_set_impl::_M_try_emplace overload
All checks were successful
/ format-checks (pull_request) Successful in 1m35s
Details
e20d1cf71b 
Remove the unused template parameter pack _Args (which always gets
deduced to an empty pack).

libstdc++-v3/ChangeLog:

	* include/std/flat_set (_Flat_set_impl::_M_try_emplace):
	Turn nullary overload into a non-template.
forge-bot commented 2026-07-15 20:07:18 +00:00
Member
Copy link

Hi @ppalka. This bot helps send your PR as a patch series to the mailing list.

Next steps

  1. Write a clear PR description. It will be used as the cover letter.
  2. To CC extra people, add lines like this at the end of the PR description: CC: Reviewer1 <revi.ewer@example.com>, Reviewer2 <an.other@example.com>.
  3. To preview the emails, comment with /preview.
  4. When ready, request review in the Reviewers section. Or, if you just want to send the series, comment with /submit.
  5. Use the cover-letter links below to follow replies.
  6. For a new patch series, push your changes, update the PR description with a Changes since vX section, and comment with /submit again.

See Submitting Patches and UsingForge.

Consider joining the gcc and gcc-patches mailing lists..
For real time communication, check the gcc irc channels.

Or join #overseers on Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).

<!-- pr-welcome --> Hi @ppalka. This bot helps send your PR as a patch series to the mailing list. ## Next steps 1. Write a clear PR description. It will be used as the cover letter. 2. To CC extra people, add lines like this **at the end** of the PR description: `CC: Reviewer1 <revi.ewer@example.com>, Reviewer2 <an.other@example.com>`. 3. To preview the emails, comment with `/preview`. 4. When ready, request review in the Reviewers section. Or, if you just want to send the series, comment with `/submit`. 5. Use the cover-letter links below to follow replies. 6. For a new patch series, push your changes, update the PR description with a `Changes since vX` section, and comment with `/submit` again. See [Submitting Patches](https://gcc.gnu.org/contribute.html#patches) and [UsingForge](https://gcc.gnu.org/wiki/UsingForge). Consider joining the [gcc and gcc-patches mailing lists.](https://gcc.gnu.org/lists.html). For real time communication, check the [gcc irc channels](https://gcc.gnu.org/wiki/GCConIRC). Or join [`#overseers`](https://web.libera.chat/#overseers) on Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).
ppalka commented 2026-07-15 20:18:18 +00:00
Author
Member
Copy link

/preview

/preview
ppalka commented 2026-07-16 13:40:11 +00:00
Author
Member
Copy link

/preview

/preview
rdfm commented 2026-07-21 17:41:43 +00:00
Owner
Copy link

/preview

/preview
🎉 1
forge-bot commented 2026-07-21 17:41:49 +00:00
Member
Copy link

Sent patch series version 1 containing 1 patches to @ppalka's email address.
Message Id of cover message is <bmm.hklvih4a3k.gcc.gcc.ppalka.189.1.0@forge-stage.sourceware.org>.

Sent patch series version 1 containing 1 patches to @ppalka's email address. Message Id of cover message is `<bmm.hklvih4a3k.gcc.gcc.ppalka.189.1.0@forge-stage.sourceware.org>`.
tkaminsk commented 2026-08-25 10:15:43 +00:00
First-time contributor
Copy link

I think you can just commit it.

I think you can just commit it.
redi approved these changes 2026-08-25 15:19:50 +00:00
tkaminsk commented 2026-08-31 11:37:10 +00:00
First-time contributor
Copy link

Pushed to trunk as 11de186f02. PR can be closed.

Pushed to trunk as 11de186f02445023bb7d6e9e001087a6e07fc0b2. PR can be closed.
All checks were successful
/ format-checks (pull_request) Successful in 1m35s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin +refs/pull/189/head:ppalka/ppalka-test-topic
git switch ppalka/ppalka-test-topic

Merge

Merge the changes and update on Forgejo.
git switch trunk
git merge --no-ff ppalka/ppalka-test-topic
git switch ppalka/ppalka-test-topic
git rebase trunk
git switch trunk
git merge --ff-only ppalka/ppalka-test-topic
git switch ppalka/ppalka-test-topic
git rebase trunk
git switch trunk
git merge --no-ff ppalka/ppalka-test-topic
git switch trunk
git merge --squash ppalka/ppalka-test-topic
git switch trunk
git merge --ff-only ppalka/ppalka-test-topic
git switch trunk
git merge ppalka/ppalka-test-topic
git push origin trunk
Sign in to join this conversation.
Reviewers
No reviewers
redi
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Frontend/ada

   
Frontend/c

   
Frontend/c++

   
Frontend/rust
Code affecting the Rust front end

  
General/forge
Forgejo infrastructure

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Library/libgcc

   
Library/libstdc++

   
Midend/gimple

   
Midend/rtl

   
Midend/tree
  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

  
Target/aarch64

   
Target/arm

   
Target/i386
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
Compat/Breaking
Frontend/ada
Frontend/c
Frontend/c++
Frontend/rust
General/forge
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Library/libgcc
Library/libstdc++
Midend/gimple
Midend/rtl
Midend/tree
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Target/aarch64
Target/arm
Target/i386
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gcc/gcc!189
No description provided.