testsuite: force arm_neon for fold-vecperm-insert-1.c on arm*-*-* #220

azoff · 2026-08-19T07:56:55Z

azoff commented

2026-08-19 07:56:55 +00:00

I've tested this change on top of r17-3309-gdf494ca28d75f8.

Ok for trunk?

--

CC: Richard.Earnshaw@arm.com

I've tested this change on top of r17-3309-gdf494ca28d75f8. Ok for trunk? -- CC: Richard.Earnshaw@arm.com

azoff added 1 commit

2026-08-19 07:56:55 +00:00

testsuite: force arm_neon for fold-vecperm-insert-1.c on arm*-*-*

/ format-checks (pull_request) Successful in 1m36s

Details

d368f3ab60

Without this change, the test is failing with

gcc.dg/fold-vecperm-insert-1.c: pattern found 0 times
FAIL: gcc.dg/fold-vecperm-insert-1.c scan-tree-dump-times forwprop3 "VEC_PERM_EXPR.*v_[0-9]+.*v_[0-9]+" 1

gcc/testsuite/ChangeLog:

	* gcc.dg/fold-vecperm-insert-1.c: Require effective target
	arm_neon for arm*-*-*.

Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>

forge-bot commented

2026-08-19 07:56:57 +00:00

Hi @azoff. This bot helps send your PR as a patch series to the mailing list.

Next steps

Write a clear PR description. It will be used as the cover letter.
To CC extra people, add lines like this at the end of the PR description: CC: Reviewer1 <revi.ewer@example.com>, Reviewer2 <an.other@example.com>.
To preview the emails, comment with /preview.
When ready, request review in the Reviewers section. Or, if you just want to send the series, comment with /submit.
Use the cover-letter links below to follow replies.
For a new patch series, push your changes, update the PR description with a Changes since vX section, and comment with /submit again.

See Submitting Patches and UsingForge.

Consider joining the gcc and gcc-patches mailing lists..
For real time communication, check the gcc irc channels.

Or join #overseers on Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).

Hi @azoff. This bot helps send your PR as a patch series to the mailing list. ## Next steps 1. Write a clear PR description. It will be used as the cover letter. 2. To CC extra people, add lines like this **at the end** of the PR description: `CC: Reviewer1 <revi.ewer@example.com>, Reviewer2 <an.other@example.com>`. 3. To preview the emails, comment with `/preview`. 4. When ready, request review in the Reviewers section. Or, if you just want to send the series, comment with `/submit`. 5. Use the cover-letter links below to follow replies. 6. For a new patch series, push your changes, update the PR description with a `Changes since vX` section, and comment with `/submit` again. See [Submitting Patches](https://gcc.gnu.org/contribute.html#patches) and [UsingForge](https://gcc.gnu.org/wiki/UsingForge). Consider joining the [gcc and gcc-patches mailing lists.](https://gcc.gnu.org/lists.html). For real time communication, check the [gcc irc channels](https://gcc.gnu.org/wiki/GCConIRC). Or join [`#overseers`](https://web.libera.chat/#overseers) on Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).

azoff commented

2026-08-19 07:57:12 +00:00

/submit

forge-bot commented

2026-08-19 07:57:45 +00:00

Version 1 of this pull request has been stored. It includes the following commits:

testsuite: force arm_neon for fold-vecperm-insert-1.c on arm*-- - d368f3ab60

Version 1 of this pull request has been stored. It includes the following commits: - testsuite: force arm_neon for fold-vecperm-insert-1.c on arm*-*-* - d368f3ab603ac2969f6e3c654ef879bcb11cb41b

forge-bot commented

2026-08-19 07:57:45 +00:00

Pull Request versions:

#	Base	Head
1	`df494ca28d`	`d368f3ab60`	(diff)

In order to compare , clone this repository and run

PR=220
git fetch origin "refs/versioned_pull/${PR}/*:refs/versioned_pull/${PR}/*"
PRV1=1
PRV2=2
git range-diff "refs/versioned_pull/${PR}/${PRV1}/base..refs/versioned_pull/${PR}/${PRV1}/head"  "refs/versioned_pull/${PR}/${PRV2}/base..refs/versioned_pull/${PR}/${PRV2}/head"

Pull Request versions: | # | Base | Head | | | - | ---- | ---- | - | | 1 | df494ca28d75f80b4d0b4e0b93b5d23d2092131a | d368f3ab603ac2969f6e3c654ef879bcb11cb41b | [(diff)](https://forge.sourceware.org/gcc/gcc.git/compare/df494ca28d75f80b4d0b4e0b93b5d23d2092131a...d368f3ab603ac2969f6e3c654ef879bcb11cb41b) | In order to compare , clone this repository and run ``` PR=220 git fetch origin "refs/versioned_pull/${PR}/*:refs/versioned_pull/${PR}/*" PRV1=1 PRV2=2 git range-diff "refs/versioned_pull/${PR}/${PRV1}/base..refs/versioned_pull/${PR}/${PRV1}/head" "refs/versioned_pull/${PR}/${PRV2}/base..refs/versioned_pull/${PR}/${PRV2}/head" ```

forge-bot commented

2026-08-19 07:58:15 +00:00

Sent patch version 1 as a single email to gcc-patches mailing list gcc-patches@gcc.gnu.org and cc'd Richard.Earnshaw@arm.com.
Cover letter

Sent patch version 1 as a single email to gcc-patches mailing list <gcc-patches@gcc.gnu.org> and cc'd Richard.Earnshaw@arm.com. [Cover letter](https://inbox.sourceware.org/gcc-patches/bmm.hlheghj3aw.gcc.gcc.azoff.220.1.0@forge-stage.sourceware.org)

rearnsha

2026-08-19 09:59:31 +00:00

added the
Target/arm
label
requested review from Maintainers.Arm

rearnsha reviewed

2026-08-19 10:02:52 +00:00

gcc/testsuite/gcc.dg/fold-vecperm-insert-1.c

					
				@ -1,5 +1,7 @@

				/* { dg-do compile { target aarch64*-*-* arm*-*-* x86_64-*-* } } */

				/* { dg-require-effective-target arm_neon_ok { target arm*-*-* } } */

				/* { dg-options "-O2 -fdump-tree-forwprop3" } */

				/* { dg-add-options arm_neon } */

Was this tested on a non-arm target? I'm not sure if this dg-add-options takes a { target arm*-*-*}, but it feels like this should be similarly restricted to the same as the d-r-e-t check.

Was this tested on a non-arm target? I'm not sure if this dg-add-options takes a `{ target arm*-*-*}`, but it feels like this should be similarly restricted to the same as the d-r-e-t check.

I've now tested it on x86_64-pc-gnu-linux too and it passes as expected.

While one might think that dg-add-options should have a target specifier, it is actually not supported.

I've now tested it on x86_64-pc-gnu-linux too and it passes as expected. While one might think that dg-add-options should have a target specifier, it is actually not supported.

azoff commented

2026-08-28 13:48:52 +00:00

Gentle ping! :)

/ format-checks (pull_request) Successful in 1m36s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u pr/gcc.dg/fold-vecperm-insert-1.c:azoff-pr/gcc.dg/fold-vecperm-insert-1.c

git switch azoff-pr/gcc.dg/fold-vecperm-insert-1.c

Merge

Merge the changes and update on Forgejo.

git switch trunk

git merge --no-ff azoff-pr/gcc.dg/fold-vecperm-insert-1.c

git switch azoff-pr/gcc.dg/fold-vecperm-insert-1.c

git rebase trunk

git switch trunk

git merge --ff-only azoff-pr/gcc.dg/fold-vecperm-insert-1.c

git switch azoff-pr/gcc.dg/fold-vecperm-insert-1.c

git rebase trunk

git switch trunk

git merge --no-ff azoff-pr/gcc.dg/fold-vecperm-insert-1.c

git switch trunk

git merge --squash azoff-pr/gcc.dg/fold-vecperm-insert-1.c

git switch trunk

git merge --ff-only azoff-pr/gcc.dg/fold-vecperm-insert-1.c

git switch trunk

git merge azoff-pr/gcc.dg/fold-vecperm-insert-1.c

git push origin trunk

Sign in to join this conversation.

No reviewers

gcc/Maintainers.Arm

No milestone

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gcc/gcc!220

Rows
Columns