Merge common attribute handling code between Rust and c-family. #241
No reviewers
Labels
No labels
Compat/Breaking
Frontend/ada
Frontend/c
Frontend/c++
Frontend/rust
General/forge
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Library/libgcc
Library/libstdc++
Midend/gimple
Midend/rtl
Midend/tree
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Target/aarch64
Target/arm
Target/i386
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gcc/gcc!241
Loading…
Reference in a new issue
No description provided.
Delete branch "imperio/gcc:rust-common-attrs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up of #207.
It merges common code for attributes handling between the Rust front-end and
attr-handlers.c. I renamed some functions by prepending them withrust_when it was also functions present inattr-handlers.h.CC: gcc-rust@gcc.gnu.org @cohenarthur
Hi @imperio. This bot helps send your PR as a patch series to the mailing list.
Next steps
CC: Reviewer1 <revi.ewer@example.com>, Reviewer2 <an.other@example.com>./preview./submit.Changes since vXsection, and comment with/submitagain.See Submitting Patches and UsingForge.
Consider joining the gcc and gcc-patches mailing lists..
For real time communication, check the gcc irc channels.
Or join
#overseerson Libera Chat, particularly if this automation is not working (stay online to get replies, IRC does not save messages if people are not online).fda2955be4d0e4c6d117/submit
The changes look good to me but the formatting seems off per our clang-format? Here is the diff when I autoformat the file. If you want to just apply that, then I'm happy to merge the changes :) Thank you!!
The forge is not showing the update but this was fixed by @imperio on his branch - I'm going to test it and merge to trunk. Thank you for your work @imperio!
@cohenarthur approved it so it was merged as commit
ef6cd7cfcf.Pull request closed